fix: avoid powershell browser opener on wsl#19
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba31aedda1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Introduces an in-repo browser opener to avoid PowerShell-based launchers on WSL (which can emit spurious console-encoding errors), replacing the previous external dependency and wiring the login flow to use it.
Changes:
- Add
internal/browser.OpenURLwith OS/WSL-specific opener selection logic (preferscmd.exeon WSL). - Add unit tests covering opener selection on Linux/WSL.
- Remove
github.com/pkg/browserfrom dependencies and update imports; minor.gitignoreupdate.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/browser/open.go |
New cross-platform URL opener with WSL-specific behavior. |
internal/browser/open_test.go |
New unit tests validating opener selection logic. |
cmd/grounds/commands/login.go |
Switch login flow to use internal/browser.OpenURL. |
go.mod |
Drop github.com/pkg/browser; promote huh to direct dependency. |
go.sum |
Remove sums associated with dropped deps / tidy. |
.gitignore |
Ignore .codex directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lusu007
force-pushed
the
fix/wsl-login-browser-open
branch
from
ba31aed to
1b0aeee
Compare
Pull Request
Description
Type of Change
Related Issues
Testing
Checklist